Convert from DRUID_INTEGRATION_TEST_INDEXER to USE_INDEXER#13684
Merged
paul-rogers merged 1 commit intoapache:masterfrom Jan 18, 2023
Merged
Convert from DRUID_INTEGRATION_TEST_INDEXER to USE_INDEXER#13684paul-rogers merged 1 commit intoapache:masterfrom
paul-rogers merged 1 commit intoapache:masterfrom
Conversation
The old ITs use DRUID_INTEGRATION_TEST_INDEXER. The new ones use the USE_INDEXER env var passed in from the build environment.
abhishekagarwal87
approved these changes
Jan 18, 2023
clintropolis
approved these changes
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old ITs use DRUID_INTEGRATION_TEST_INDEXER. The new ones use the USE_INDEXER env var passed in from the build environment.
The old ITs set an environment variable
USE_INDEXERintravis.yml, which Maven then converts toDRUID_INTEGRATION_TEST_INDEXER. The previous "indexer" PR used theDRUID_INTEGRATION_TEST_INDEXERto control the indexer settings in the new ITs.However, it turns out that the new ITs streamline the process: they just use
USE_INDEXERpassed in fromtravis.ymlwithout the (unnecessary) translation step. This PR, rips out the use ofDRUID_INTEGRATION_TEST_INDEXERin the new IT scripts and replaces that use withUSE_INDEXERso we get a simple, straight pass-through from Travis (or GHA) to the script using the shell variables without the need of mucking about in Maven.This PR has: