Auto-detect docker-compose#13754
Merged
abhishekagarwal87 merged 1 commit intoapache:masterfrom Feb 6, 2023
Merged
Conversation
cryptoe
approved these changes
Feb 5, 2023
Contributor
cryptoe
left a comment
cryptoe
left a comment
There was a problem hiding this comment.
Changes lgtm.
Thanks @paul-rogers for the fix.
clintropolis
approved these changes
Feb 6, 2023
Contributor
|
merged since failure is unrelated. |
abhagraw
pushed a commit
to abhagraw/druid
that referenced
this pull request
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super-simple change to the new ITs to automatically use
docker-composeif it is available, else attempt to use thecomposesubcommand ofdocker. Docker is moving to deprecatedocker-composein favor ofdocker compose. Some of our build environments use one version, some another. This change should allow the IT scripts to work regardless of how Compose is packaged.No release note or doc impact.
This PR has: