Code cleanup & message improvements#13778
Merged
abhishekagarwal87 merged 5 commits intoapache:masterfrom Feb 15, 2023
Merged
Conversation
Correct spacing Add type parameters Add toString() methods to formats so tests compare correctly IT doc revisions Error message edits Display UT query results when tests fail
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+149
to
+152
| return "FlatTextInputFormat{" | ||
| + "delimiter=\"" + delimiter | ||
| + "\"listDelimiter=" | ||
| + listDelimiter == null ? "null" : "\"" + listDelimiter + "\"" |
Check warning
Code scanning / CodeQL
Useless null check
abhishekagarwal87
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a collection if minor edits done as part of the Catalog project. Pulled out here to reduce the size of the catalog PR.
The edits include:
toString()methods to formats so tests compare correctly. Without this, an UT with an external data source will fail if the two formats are not the same object. The change allows comparison as long as the two formats have identical values.queryfield if it isnull. (Else, the original error is masked by an NPE in the logging code.)No substantial changes are in the PR.
Release note
No user-visible changes.
This PR has: