SuperSorter: Avoid storing extra writable channels.#13915
Closed
gianm wants to merge 1 commit intoapache:masterfrom
Closed
SuperSorter: Avoid storing extra writable channels.#13915gianm wants to merge 1 commit intoapache:masterfrom
gianm wants to merge 1 commit intoapache:masterfrom
Conversation
PR apache#13368 replaced a FrameFile cache with a PartitionedOutputChannel cache. Unfortunately, these objects are heavyweight: each has a writable channel and a frame memory allocator with an 8MB arena. This patch replaces it with a Supplier<PartitionedReadableFrameChannel>, which is lighter weight, and is all that was needed anyway.
gianm
added
Bug
Area - MSQ
Contributor
Author
|
#13755 fixes the same bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #13368 replaced a FrameFile cache with a PartitionedOutputChannel cache. Unfortunately, these objects are heavyweight: each has a writable channel and a frame memory allocator with an 8MB arena. This patch replaces it with a Supplier, which is lighter weight, and is all that was needed anyway.