Fixes parquet uint_32 datatype conversion#13935
Merged
abhishekagarwal87 merged 2 commits intoapache:masterfrom Mar 16, 2023
Merged
Fixes parquet uint_32 datatype conversion#13935abhishekagarwal87 merged 2 commits intoapache:masterfrom
abhishekagarwal87 merged 2 commits intoapache:masterfrom
Conversation
Member
Author
|
@clintropolis Could you please review this PR? |
clintropolis
approved these changes
Mar 15, 2023
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
my bad on introducing this bug, thanks for the fix 👍
| case UINT_16: | ||
| return g.getInteger(fieldIndex, index); | ||
| case UINT_32: | ||
| return g.getInteger(fieldIndex, index) & (-1L >>> 32); |
Member
There was a problem hiding this comment.
this could also use Integer.toUnsignedLong
Member
Author
There was a problem hiding this comment.
Fixed it, Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
After parquet ingestion, uint_32 parquet datatypes are stored as null values in the dataSource. This PR fixes this conversion bug.
Key changed/added classes in this PR
ParquetGroupConverter.javaThis PR has: