Skip to content

Cache mvn dependencies for cron workflow ITs#13962

Merged
abhishekagarwal87 merged 1 commit intoapache:masterfrom
tejaswini-imply:fix-cron-job-builds
Mar 29, 2023
Merged

Cache mvn dependencies for cron workflow ITs#13962
abhishekagarwal87 merged 1 commit intoapache:masterfrom
tejaswini-imply:fix-cron-job-builds

Conversation

@tejaswini-imply
Copy link
Member

@tejaswini-imply tejaswini-imply commented Mar 22, 2023

  • With this PR, mvn dependencies are cached prior to running jdk11 ITs in cron workflow.
  • Only security-vulnerabilities job in this workflow runs on PR if there are changes to owasp-dependency-check-suppressions.xml file.

@tejaswini-imply tejaswini-imply changed the title Cache mvn dependencies for cron job tests Cache mvn dependencies for cron workflow ITs Mar 22, 2023
- name: Maven build
id: maven_build
run: |
./it.sh ci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works for old IT workflow as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, build happens the same way independently in the old (standard&revised) IT workflow. Also, old IT workflow builds docker container for revised ITs. Its not needed here as of now.

@abhishekagarwal87 abhishekagarwal87 merged commit 3c096c0 into apache:master Mar 29, 2023
- name: Checkout branch
uses: actions/checkout@v3

- name: setup java
Copy link
Contributor

@imply-elliott imply-elliott Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, we're using the on-runner java now to save time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that, I have used this setup only for security_vulnerabilities job to take the advantage of GHA powered maven cache and incase of CVE suppression PRs security_vulnerabilities job alone runs and still cache maven dependencies across workflows.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. However, we can do the same by using the same caching parameters the setup java action uses, which just follows this convention: https://github.com/actions/cache/blob/0638051e9af2c23d10bb70fa9beffcad6cff9ce3/examples.md#java---maven
Again, not a big deal, but will save a bit of time downloading and setting up java.

@asdf2014 asdf2014 added the Area - Dev For items related to the project itself, like dev docs and checklists, but not CI label Mar 31, 2023
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Dev For items related to the project itself, like dev docs and checklists, but not CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants