Cache mvn dependencies for cron workflow ITs#13962
Cache mvn dependencies for cron workflow ITs#13962abhishekagarwal87 merged 1 commit intoapache:masterfrom
Conversation
| - name: Maven build | ||
| id: maven_build | ||
| run: | | ||
| ./it.sh ci |
There was a problem hiding this comment.
this works for old IT workflow as well?
There was a problem hiding this comment.
Yes, build happens the same way independently in the old (standard&revised) IT workflow. Also, old IT workflow builds docker container for revised ITs. Its not needed here as of now.
| - name: Checkout branch | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: setup java |
There was a problem hiding this comment.
Just a note, we're using the on-runner java now to save time.
There was a problem hiding this comment.
I understand that, I have used this setup only for security_vulnerabilities job to take the advantage of GHA powered maven cache and incase of CVE suppression PRs security_vulnerabilities job alone runs and still cache maven dependencies across workflows.
There was a problem hiding this comment.
That makes sense. However, we can do the same by using the same caching parameters the setup java action uses, which just follows this convention: https://github.com/actions/cache/blob/0638051e9af2c23d10bb70fa9beffcad6cff9ce3/examples.md#java---maven
Again, not a big deal, but will save a bit of time downloading and setting up java.
owasp-dependency-check-suppressions.xmlfile.