Add msqDenySelect planner config to (dis)allow MSQ SELECT queries.#13992
Add msqDenySelect planner config to (dis)allow MSQ SELECT queries.#13992abhishekrb19 wants to merge 3 commits intoapache:masterfrom
msqDenySelect planner config to (dis)allow MSQ SELECT queries.#13992Conversation
abhishekrb19
force-pushed
the
ingest_only_querycontext_taskapi
branch
from
7a948ac to
d4f0db8
Compare
|
It looks like only 1 GHA check ran. The tests didn't seem to run |
abhishekrb19
changed the title
msqDenySelect query context parameter to (dis)allow MSQ SELECT queries.msqDenySelect planner context config to (dis)allow MSQ SELECT queries.
abhishekrb19
changed the title
msqDenySelect planner context config to (dis)allow MSQ SELECT queries.msqDenySelect planner config to (dis)allow MSQ SELECT queries.
| @Test | ||
| public void testMsqDenySelectEnabledQuery() | ||
| { | ||
| msqCompatible(); |
There was a problem hiding this comment.
These tests probably want to be in CalciteInsertDmlTest, if they can share config. Those tests are run only for MSQ. The test in this form runs for both MSQ and non-MSQ, which may not be what you wanted.
| } | ||
|
|
||
| @Test | ||
| public void testMsqDenySelectDisabledQuery() |
There was a problem hiding this comment.
A test that denies access should probably expect an error, I would think.
| public static final boolean DEFAULT_ENABLE_DEBUG = false; | ||
| public static final int DEFAULT_IN_SUB_QUERY_THRESHOLD = Integer.MAX_VALUE; | ||
| public static final boolean DEFAULT_ENABLE_TIME_BOUNDARY_PLANNING = false; | ||
| public static final boolean DEFAULT_MSQ_DENY_SELECT = false; |
This's because the ASF recently requires committers to click a 'apporve' button to run CI. We discussed this matter in dev mailing thread and wanted to change it back. |
FrankChen021
added
the
Area - MSQ
|
Closing this in favor of a different approach which would include query kind in the |
3 participants
Description
This PR adds a new planner configuration
msqDenySelectthat, when set to true, MSQSELECTstatements will be blocked from planning. This parameter is set tofalseby default, so all queries will plan.This PR has: