Skip to content

New error message for task deletion#14008

Merged
clintropolis merged 2 commits intoapache:masterfrom
georgew5656:handle404
Apr 3, 2023
Merged

New error message for task deletion#14008
clintropolis merged 2 commits intoapache:masterfrom
georgew5656:handle404

Conversation

@georgew5656
Copy link
Contributor

Description

The fabric8 API returns false only if the K8s API returns a 404 on a delete attempt (resource not found). If there is a actual error than fabric8 will rethrow the client exception. Updating the log message to account for this.

See:
https://javadoc.io/static/io.fabric8/kubernetes-client/4.6.4/io/fabric8/kubernetes/client/dsl/base/BaseOperation.html#delete--

Key changed/added classes in this PR

Update DruidKubernetesPeonClient to handle false results from job.delete() differently.
This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@clintropolis clintropolis merged commit 4560b9d into apache:master Apr 3, 2023
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants