Remove maxResultsSize config property from S3OutputConfig#14101
Merged
cryptoe merged 6 commits intoapache:masterfrom Apr 18, 2023
Merged
Remove maxResultsSize config property from S3OutputConfig#14101cryptoe merged 6 commits intoapache:masterfrom
cryptoe merged 6 commits intoapache:masterfrom
Conversation
cryptoe
reviewed
Apr 17, 2023
|
|
||
| @JsonProperty | ||
| private HumanReadableBytes maxResultsSize = new HumanReadableBytes("100MiB"); | ||
| private HumanReadableBytes chunkSize = new HumanReadableBytes("100MiB"); |
Contributor
There was a problem hiding this comment.
Do we still need :
public static final long S3_MULTIPART_UPLOAD_MIN_OBJECT_SIZE_BYTES = 5L * 1024*1024;
public static final long S3_MULTIPART_UPLOAD_MAX_OBJECT_SIZE_BYTES = 5L * 1024 * 1024 * 1024 * 1024;
|
|
||
| @Nullable | ||
| @JsonProperty | ||
| private HumanReadableBytes chunkSize; |
Contributor
There was a problem hiding this comment.
Please update the documentation also.
The release notes should mention that the defaults have changed and the value is removed.
cryptoe
reviewed
Apr 17, 2023
Co-authored-by: Karan Kumar <karankumar1100@gmail.com>
cryptoe
approved these changes
Apr 18, 2023
Contributor
cryptoe
left a comment
cryptoe
left a comment
There was a problem hiding this comment.
LGTM. Just waiting for a green build.
cryptoe
pushed a commit
that referenced
this pull request
Apr 18, 2023
* "maxResultsSize" has been removed from the S3OutputConfig and a default "chunkSize" of 100MiB is now present. This change primarily affects users who wish to use durable storage for MSQ jobs. (cherry picked from commit 8eb854c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the property
maxResultsSizefrom the S3OutputConfig. That property was used to limit the max size that can be fetched from the S3 (and used primarily in the durable storage of MSQ).However, since we now chunk downloads from S3, we donot need such a guardrail and the property can be removed from the config.
Moreover, a default chunk size of 100MiB has been introduced (earlier it was calculated based on the value passed in the
maxResultsSize). RemovingmaxResultsSizealso clears up the hurdles associated with calculating the appropriate chunkSize.Release note
"maxResultsSize" has been removed from the S3OutputConfig and a default "chunkSize" of 100MiB is now present. This change primarily affects users who wish to use durable storage for MSQ jobs.
Key changed/added classes in this PR
S3OutputConfigRetryableS3OutputStreamThis PR has: