Updating segment map function for QueryDataSource to ensure group by …#14112
Merged
clintropolis merged 3 commits intoapache:masterfrom Apr 20, 2023
Merged
Updating segment map function for QueryDataSource to ensure group by …#14112clintropolis merged 3 commits intoapache:masterfrom
clintropolis merged 3 commits intoapache:masterfrom
Conversation
…of group by of join data source gets into proper segment map function path
Contributor
Author
Contributor
|
If you additionally add a test to the |
imply-cheddar
approved these changes
Apr 19, 2023
Contributor
imply-cheddar
left a comment
There was a problem hiding this comment.
Approving as this is good for now. But please add the test to QueryDataSourceTest so that coverage robot is happy too.
clintropolis
approved these changes
Apr 20, 2023
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
Apr 20, 2023
apache#14112) * Updating segment map function for QueryDataSource to ensure group by of group by of join data source gets into proper segment map function path * Adding unit tests for the failed case * There you go coverage bot, be happy now
clintropolis
added a commit
that referenced
this pull request
Apr 21, 2023
#14112) (#14134) * Updating segment map function for QueryDataSource to ensure group by of group by of join data source gets into proper segment map function path * Adding unit tests for the failed case * There you go coverage bot, be happy now Co-authored-by: Soumyava <93540295+somu-imply@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

…of group by of join data source gets into proper segment map function path
A query such as
was producing nulls as the Segment map function of Join was not called as the Inner Query Data source's segment map function was returning an identity function. Changed the query data source's segment map function which should delegate to the segment map function of the subquery's datasource. The test now passes.
Fixes #14088
This PR has: