Web console: better end of (MSQ) query segment loading UX#14120
Merged
vogievetsky merged 7 commits intoapache:masterfrom Apr 20, 2023
Merged
Web console: better end of (MSQ) query segment loading UX#14120vogievetsky merged 7 commits intoapache:masterfrom
vogievetsky merged 7 commits intoapache:masterfrom
Conversation
cryptoe
approved these changes
Apr 20, 2023
vogievetsky
added a commit
to vogievetsky/druid
that referenced
this pull request
Apr 20, 2023
* better end of query segment loading UX * fix snapshot * handle case when MSQ query returns results directly * add ip address column icon * better icons * add variance icon * better summary
vogievetsky
added a commit
that referenced
this pull request
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a bit of code cleanup (coming up with better names and structure, adding comments) as well as adding a high level timeout to the "wait for segments to be loaded" cycle that happens at the end of an MSQ query.
Also change the action in the console from "(stop waiting)" to "(skip waiting)" which seems more inviting (and accurate).