Fix GHA workflows naming & Run ITs if UTs fail on coverage#14158
Merged
abhishekagarwal87 merged 16 commits intoapache:masterfrom May 22, 2023
Merged
Conversation
|
|
||
| - name: Debug IT | ||
| if: steps.run-it.conclusion == 'failure' | ||
| if: ${{ failure() && steps.run-it.conclusion == 'failure' }} |
Contributor
There was a problem hiding this comment.
what's the reason behind this change?
Member
Author
There was a problem hiding this comment.
https://docs.github.com/en/actions/learn-github-actions/expressions#failure-with-conditions It needs failure() check, else this step gets skipped, which is happening so far https://github.com/apache/druid/actions/runs/4852046053/jobs/8694134189?pr=14137.
Member
Author
|
Thanks @abhishekagarwal87 for the review, I have addressed your comments in latest commit. |
abhishekagarwal87
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to run ITs if unit-tests fail on coverage. This PR allows Revised, Standard ITs to run when unit-tests fail on coverage errors, still failing the workflow. This PR also fixes existing GHA workflow naming.