Ephemeral storage is respected from the overlod for peon tasks#14201
Merged
gianm merged 1 commit intoapache:masterfrom May 5, 2023
Merged
Ephemeral storage is respected from the overlod for peon tasks#14201gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
I am not a k8s expert so this is perhaps a basic question, but: is the effect of this that task pods will end up with the same ephemeral storage requirement as the Overlord pod that launched them? If so I don't understand why this is necessarily good -- wouldn't tasks generally need different amount of storage than the Overlord? |
Contributor
Author
|
@gianm this is a good point, i want to inherit properly from the overlord, then have another PR to override. But first I should be doing the right thing, unless you think both can go in this PR. If you don't inherit, you use the default value, which is immutable....you can't change it. |
Contributor
|
Got it, that makes sense. It's ok to do the next step as a follow-up IMO, so I'll merge this one. |
gianm
approved these changes
May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed during testing that the ephemeral storage resource was not inherited from the overlord. We should only be overriding the specific "cpu" and "memory" resources, currently we are calculating cpu/memory and only setting those. We should inherit all the other resources and only override
cpuandmemory