Skip to content

Adding the test for OR condition in join clause#14400

Closed
pranavbhole wants to merge 1 commit intoapache:masterfrom
pranavbhole:addJoinORtest
Closed

Adding the test for OR condition in join clause#14400
pranavbhole wants to merge 1 commit intoapache:masterfrom
pranavbhole:addJoinORtest

Conversation

@pranavbhole
Copy link
Copy Markdown
Contributor

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • [] added documentation for new or modified features or behaviors.
  • [] a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

"SELECT foo.dim1, foo.dim2, l.k, l.v\n"
+ "FROM foo INNER JOIN lookup.lookyloo l ON CHARACTER_LENGTH(foo.dim2 || l.k) > 3\n",
"Possible error: SQL requires a join with 'GREATER_THAN' condition that is not supported."
"Possible error: SQL requires a join with 'GREATER_THAN' condition that is not supported.",
Copy link
Copy Markdown
Member

@rohangarg rohangarg Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavbhole : A side cleanup request on this :)
Can we move the join related unplannable cases to CalciteJoinQueryTest - that class already contains testJoinOnConstantShouldFail - we can probably put all the join cases together in a single case like this test case. what do you think?

@github-actions
Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 13, 2024
@github-actions
Copy link
Copy Markdown

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants