allow expression "best effort" type determination to better handle mixed type arrays#14438
Merged
clintropolis merged 2 commits intoapache:masterfrom Jun 16, 2023
Conversation
imply-cheddar
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues that can happen during ingestion of 'auto' typed columns which receive input with mixed type arrays; Druid ARRAY types only support all elements of the same type. The ARRAY "best effort" code has been modified to use the "least restrictive" logic that is now also used by default for the computed SQL schema, allowing things like
[["a", "b", "c"], {"x": 123}]to now be handled asARRAY<COMPLEX<json>>rather than throwing an incompatible type exception.This PR has: