Fix compatibility issue with SqlTaskResource#14466
Merged
cheddar merged 2 commits intoapache:masterfrom Jun 23, 2023
Merged
Conversation
The DruidException changes broke the response format for errors coming back from the SqlTaskResource, so fix those
Contributor
|
The other_modules tests are complaining because the SqlTaskResource apparently never had tests put on it, so there's no coverage. This PR is just fixing the known compatibility issue and not fixing the fact that tests were never actually created to help catch such issues in the first place. There also appears to be a flakey test in processing around HttpConfig. I've seen it pass and fail multiple times over now, I do not know why, but the CI has been pretty flakey with this PR and fighting with it to get clean green checks is just going to waste energy. So I'm going to merge as is. |
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
* Fix compatibility issue with SqlTaskResource The DruidException changes broke the response format for errors coming back from the SqlTaskResource, so fix those
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DruidExceptionchanges broke the response format for errors coming back from theSqlTaskResource