Make GuavaUtilsTest use less CPU#14487
Merged
clintropolis merged 1 commit intoJun 27, 2023
Merged
Conversation
gianm
approved these changes
Jun 27, 2023
clintropolis
approved these changes
Jun 27, 2023
Member
|
this PR looks like it cuts the running time of the druid-processing unit tests in half 👍 |
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GuavaUtilsTest.testCancelAllis currently spinning up 3 threads, putting them in an infinite loop and then only causing one to exit. This means that 2 threads are continuing to run in the background for the entire lifetime of the surefire run just doing their infinite loop thing. Either way, the infinite loop is a poor way of doing the concurrent validation anyway, so switch it to do a proper validation with countdown latches and tasks that always exit.