Allow multiple consoleAppender to be used in peon logging

[maytasm]

Fixes ConsoleLoggingEnforcementConfigurationFactory would still enforce an additional ConsoleAppender if there are multiple ConsoleAppender defined

Description

The PR #14094 allow for multiple/existing log4j appenders to be kept when there is a ConsoleAppender configured for a Logger. However, this doesn't work as expected when there are multiple ConsoleAppender defined. The function ConsoleLoggingEnforcementConfigurationFactory#findConsoleAppender currently only considered the first ConsoleAppender it finds and verify that this ConsoleAppender is set in the Loggers. However, this fails to consider that multiple ConsoleAppenders could be defined. When we ensure there is a console logger defined for each Logger (in the function ConsoleLoggingEnforcementConfigurationFactory#applyConsoleAppender), we should make it such that ANY of the defined ConsoleAppender is sufficient (not just the first ConsoleAppender in the list)

This PR has:

• been self-reviewed.
  • using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
• added documentation for new or modified features or behaviors.
• a release note entry in the PR description.
• added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
• added or updated version, license, or notice information in licenses.yaml
• added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
• added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
• added integration tests.
• been tested in a test Druid cluster.

[abhishekrb19]

LGTM. One minor comment

[abhishekrb19]

I think this should be @Nonnull rather than @NotNull as there's no validation

[maytasm]

Good catch. Thanks

[maytasm]

CC: @suneet-s @TSFenwick

[suneet-s]

When testing this change without specifying a Console appender, I see this in the task logs.

19:25:12.045 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger root. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger root. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.initialization. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.skife.config. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.segment. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.kafka.clients.consumer.internals. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.server.QueryResource. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.server.coordinator. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger com.sun.jersey.guice. Using _Injected_Console_Appender_ instead.
19:25:12.048 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.server.QueryLifecycle. Using _Injected_Console_Appender_ instead.
2023-07-17 19:25:12,218 main ERROR Attempted to append to non-started appender _Injected_Console_Appender_

I know this is not part of this change, as I have seen this error before this patch. Since you are changing the code, could you look into why the injected console appender is not started

[suneet-s]

+1 on the approach, thank you!

[maytasm]

When testing this change without specifying a Console appender, I see this in the task logs.

19:25:12.045 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger root. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger root. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.initialization. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.skife.config. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.segment. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.kafka.clients.consumer.internals. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.server.QueryResource. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.server.coordinator. Using _Injected_Console_Appender_ instead.
19:25:12.047 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger com.sun.jersey.guice. Using _Injected_Console_Appender_ instead.
19:25:12.048 [main] WARN  org.apache.druid.indexing.common.tasklogs.ConsoleLoggingEnforcementConfigurationFactory - Clearing all configured appenders for logger org.apache.druid.server.QueryLifecycle. Using _Injected_Console_Appender_ instead.
2023-07-17 19:25:12,218 main ERROR Attempted to append to non-started appender _Injected_Console_Appender_

I know this is not part of this change, as I have seen this error before this patch. Since you are changing the code, could you look into why the injected console appender is not started

This error is not introduced by my change. The error is due to the created _Injected_Console_Appender_ not being started. I went and fix this and include it in this PR.