Handle dimensionless group by queries with partitioning#14522
Merged
cryptoe merged 1 commit intoapache:masterfrom Jul 7, 2023
Merged
Handle dimensionless group by queries with partitioning#14522cryptoe merged 1 commit intoapache:masterfrom
cryptoe merged 1 commit intoapache:masterfrom
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In MSQ, queries of the following sorts fail:
This is a bug in the
GroupByQueryKitbecause the absence of the dimensions causes the query kit to push everything into a single partition (usingGlobalSortMaxCountShuffleSpec) however this shuffle spec doesn't support "buckets", which is needed in case the PARTITIONED BY is present.The fix involves adding an additional check to ensure that the bucketing is not present in the clustering columns.
Note 1: There can be multiple fixes for the above, and the current code should have worked as well if there was no sanity check in the
GlobalSortMaxCountShuffleSpecclass since we will ultimately get a single row in all the cases.Note 2: The query would fail if the time was populated by an aggregator instead of a post-aggregator (expression)
Key changed/added classes in this PR
GroupByQueryKitThis PR has: