Skip to content

Comments

Add service/heartbeat metric into statsd-reporter#14564

Merged
suneet-s merged 1 commit intoapache:masterfrom
YongGang:add-health-metrics
Jul 11, 2023
Merged

Add service/heartbeat metric into statsd-reporter#14564
suneet-s merged 1 commit intoapache:masterfrom
YongGang:add-health-metrics

Conversation

@YongGang
Copy link
Contributor

Description

This is a follow up change to #14443 which added a new metric service/heartbeat for monitoring service health.

Release note

Expose service/heartbeat metric to statsd-reporter.


Key changed/added classes in this PR
  • add a new entry in defaultMetricDimensions.json to expose the new metric to statsd-reporter

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@YongGang
Copy link
Contributor Author

Thanks for your review @kfaraz , since I don't have write access could you help merge the change if it looks good to you?

@suneet-s suneet-s merged commit 0ca3ba0 into apache:master Jul 11, 2023
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
@YongGang YongGang deleted the add-health-metrics branch August 3, 2023 01:19
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants