Add test for ReservoirSegmentSampler#14591
Merged
kfaraz merged 3 commits intoapache:masterfrom Jul 17, 2023
Merged
Conversation
AmatyaAvadhanula
approved these changes
Jul 17, 2023
Contributor
AmatyaAvadhanula
left a comment
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
Thank you, @kfaraz. LGTM.
Contributor
Author
|
Thanks for the review, @AmatyaAvadhanula ! I have added some more comments as discussed with you offline. |
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
Tests to verify the following behaviour have been added: - Segments from more populous servers are more likely to be picked irrespective of sample size. - Segments from all servers are equally likely to be picked if all servers have equivalent number of segments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests to verify the following behaviour have been added: