Skip to content

Comments

Expose leader dimension in service/heartbeat metric into statsd-reporter#14593

Merged
kfaraz merged 1 commit intoapache:masterfrom
YongGang:expose-metric-dimension
Jul 17, 2023
Merged

Expose leader dimension in service/heartbeat metric into statsd-reporter#14593
kfaraz merged 1 commit intoapache:masterfrom
YongGang:expose-metric-dimension

Conversation

@YongGang
Copy link
Contributor

Description

leader dimension should be exposed in service/heartbeat metric into statsd-reporter, need to summarize in this dimension for alerting.

Release note

Expose leader dimension in service/heartbeat metric into statsd-reporter


Key changed/added classes in this PR
  • Modify the service/heartbeat metric entry in defaultMetricDimensions.json to expose the leader dimension.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz merged commit 214f7c3 into apache:master Jul 17, 2023
sergioferragut pushed a commit to sergioferragut/druid that referenced this pull request Jul 21, 2023
@YongGang YongGang deleted the expose-metric-dimension branch August 3, 2023 01:18
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants