Skip to content

Handle taskIds which are not found in the overlord correctly#14706

Merged
abhishekagarwal87 merged 2 commits intoapache:masterfrom
adarshsanjeev:handle_task_ids_not_found
Jul 31, 2023
Merged

Handle taskIds which are not found in the overlord correctly#14706
abhishekagarwal87 merged 2 commits intoapache:masterfrom
adarshsanjeev:handle_task_ids_not_found

Conversation

@adarshsanjeev
Copy link
Contributor

@adarshsanjeev adarshsanjeev commented Jul 31, 2023

This PR has fixes a bug in the SqlStatementAPI where if the task is not found on the overlord, the response status is 500.
This changes the response to invalid input since the queryID passed is not valid.

This is a copy of #14687 with comments addressed

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 31, 2023
@abhishekagarwal87 abhishekagarwal87 merged commit 21d023b into apache:master Jul 31, 2023
adarshsanjeev added a commit to adarshsanjeev/druid that referenced this pull request Jul 31, 2023
@adarshsanjeev
Handle taskIds which are not found in the overlord correctly (apache#…
d5e9098 
…14706)

This PR has fixes a bug in the SqlStatementAPI where if the task is not found on the overlord, the response status is 500.
This changes the response to invalid input since the queryID passed is not valid.
@adarshsanjeev adarshsanjeev mentioned this pull request Jul 31, 2023
Merged
10 tasks
@cryptoe cryptoe mentioned this pull request Aug 1, 2023
Closed
9 tasks
abhishekagarwal87 pushed a commit that referenced this pull request Aug 1, 2023
@adarshsanjeev
Handle taskIds which are not found in the overlord correctly (#14706) (…
d0a3032 
…#14709)

This PR has fixes a bug in the SqlStatementAPI where if the task is not found on the overlord, the response status is 500.
This changes the response to invalid input since the queryID passed is not valid.
@cryptoe cryptoe mentioned this pull request Aug 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

27.0

Development

Successfully merging this pull request may close these issues.

2 participants

@adarshsanjeev @abhishekagarwal87