prometheus-emitter: add extraLabels parameter#14728
Merged
abhishekrb19 merged 4 commits intoapache:masterfrom Aug 29, 2023
Merged
prometheus-emitter: add extraLabels parameter#14728abhishekrb19 merged 4 commits intoapache:masterfrom
abhishekrb19 merged 4 commits intoapache:masterfrom
Conversation
8 tasks
Contributor
|
Took a quick glance and it looks good, but need to actually review it tomorrow :) |
ektravel
reviewed
Aug 7, 2023
Contributor
ektravel
left a comment
ektravel
left a comment
There was a problem hiding this comment.
Changes to prometheus.md look good.
Contributor
Author
|
@TSFenwick Thanks. Whenever you can dive deeper, would be great. Cheers! |
Contributor
abhishekrb19
left a comment
abhishekrb19
left a comment
There was a problem hiding this comment.
The approach looks good to me. I left a few suggestions.
...theus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java
Outdated
Show resolved
Hide resolved
...theus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java
Outdated
Show resolved
Hide resolved
.../prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitter.java
Outdated
Show resolved
Hide resolved
...theus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks @abhishekrb19, I made the changes. |
abhishekrb19
approved these changes
Aug 28, 2023
Contributor
abhishekrb19
left a comment
abhishekrb19
left a comment
There was a problem hiding this comment.
LGTM. Thank you for this patch, @yianni!
jakubmatyszewski
pushed a commit
to jakubmatyszewski/druid
that referenced
this pull request
Sep 8, 2023
* prometheus-emitter: add extraLabels parameter * prometheus-emitter: update readme to include the extraLabels parameter * prometheus-emitter: remove nullable and surface label name issues * remove import to make linter happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Building on previous work (#14659), this PR introduces the ability to add additional labels to Prometheus metrics, providing more flexibility for data management and identification. This change is particularly useful when managing various types of data across multiple Druid clusters.
The additional labels can be set using a new optional configuration parameter (
druid.emitter.prometheus.extraLabels) added to the Prometheus emitter.Changes Made
druid.emitter.prometheus.extraLabels) to the Prometheus emitter.Release note
The Prometheus emitter now supports a new optional configuration parameter,
druid.emitter.prometheus.extraLabels. This addition offers users the flexibility to add arbitrary extra labels to their Prometheus metrics, providing more granular control in managing and identifying data across multiple Druid clusters or other dimensions.Key changed/added classes in this PR:
This PR has: