Automatic compaction API documentation refactor#14740
Merged
vtlim merged 11 commits intoapache:masterfrom Aug 21, 2023
Merged
Conversation
ektravel
reviewed
Aug 7, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
ektravel
reviewed
Aug 10, 2023
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
vtlim
reviewed
Aug 11, 2023
Member
vtlim
left a comment
vtlim
left a comment
There was a problem hiding this comment.
Overall nice improvements. Left some minor comments and a few things to suss out (different values for max tasks listed, and suggested content rearrangement)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Automatic compaction API documentation.
Preview: https://druid-git-automatic-compaction-doc-refactor-demo-kratia.vercel.app/docs/api-reference/automatic-compaction-api.html
This PR has: