Skip to content

Adding data generation pod to jupyter notebooks deployment#14742

Merged
vtlim merged 29 commits intoapache:masterfrom
sergioferragut:datagen-server
Aug 10, 2023
Merged

Adding data generation pod to jupyter notebooks deployment#14742
vtlim merged 29 commits intoapache:masterfrom
sergioferragut:datagen-server

Conversation

@sergioferragut
Copy link
Contributor

@sergioferragut sergioferragut commented Aug 3, 2023

Description

  • Added datagen container to docker_compose
  • Added an introduction notebook that teaches users how to generate data into files or streams
  • Adjusted the existing streaming notebook to use the datagen service to populate the topic
  • Removed unnecessary python modules from jupyter notebooks

Release note

Jupyter Labs quick start now contains a data generator to create batch or streaming data on demand.

This PR has:

  • been self-reviewed.
  • using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@sergioferragut sergioferragut marked this pull request as ready for review August 3, 2023 01:40
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this in Docker Compose / Jupyter yet. Biggest question is making the build available to folks who don't want to pull from a 3rd party.

sergioferragut and others added 8 commits August 4, 2023 10:07
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
@vtlim
Copy link
Member

vtlim commented Aug 4, 2023

The changes in the PR may warrant an update to Dockerfile. We could at least remove this comment:

# WIP -- install DruidDataDriver as a package
# Import data generator and configuration file
# Change permissions to allow import (requires sudo privileges)

Does this need to change too?

# Add location of the data generator to PYTHONPATH
ENV PYTHONPATH "${PYTHONPATH}:/home/jovyan/notebooks/02-ingestion"

Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a review on the new notebook. I can't get it to work locally yet.

sergioferragut and others added 5 commits August 7, 2023 10:28
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebooks work great 👍 Left some nits on content. The only major thing is to update the Prerequisites for the Kafka notebook on using the data generator and providing guidance on how to run the notebook if you didn't use Docker.

sergioferragut and others added 5 commits August 9, 2023 13:37
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…1-streaming-from-kafka.ipynb

Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…1-streaming-from-kafka.ipynb

Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…1-streaming-from-kafka.ipynb

Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Sergio Ferragut and others added 4 commits August 9, 2023 15:14
…n/02-datagen-intro.ipynb

Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…n/02-datagen-intro.ipynb

Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after a few remaining nits. Really nice work!

@vtlim vtlim merged commit 353f7be into apache:master Aug 10, 2023
@sergioferragut sergioferragut deleted the datagen-server branch August 10, 2023 22:48
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants