Adding data generation pod to jupyter notebooks deployment#14742
Adding data generation pod to jupyter notebooks deployment#14742vtlim merged 29 commits intoapache:masterfrom
Conversation
techdocsmith
left a comment
There was a problem hiding this comment.
Haven't tested this in Docker Compose / Jupyter yet. Biggest question is making the build available to folks who don't want to pull from a 3rd party.
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
|
The changes in the PR may warrant an update to Dockerfile. We could at least remove this comment: druid/examples/quickstart/jupyter-notebooks/Dockerfile Lines 51 to 53 in 62ddeaf Does this need to change too? druid/examples/quickstart/jupyter-notebooks/Dockerfile Lines 64 to 65 in 62ddeaf |
vtlim
left a comment
There was a problem hiding this comment.
Left a review on the new notebook. I can't get it to work locally yet.
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Show resolved
Hide resolved
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Charles Smith <techdocsmith@gmail.com>
…n/02-datagen-intro.ipynb Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
vtlim
left a comment
There was a problem hiding this comment.
The notebooks work great 👍 Left some nits on content. The only major thing is to update the Prerequisites for the Kafka notebook on using the data generator and providing guidance on how to run the notebook if you didn't use Docker.
examples/quickstart/jupyter-notebooks/notebooks/02-ingestion/01-streaming-from-kafka.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/02-ingestion/01-streaming-from-kafka.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/02-ingestion/01-streaming-from-kafka.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Outdated
Show resolved
Hide resolved
examples/quickstart/jupyter-notebooks/notebooks/01-introduction/02-datagen-intro.ipynb
Show resolved
Hide resolved
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…1-streaming-from-kafka.ipynb Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…1-streaming-from-kafka.ipynb Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…1-streaming-from-kafka.ipynb Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…n/02-datagen-intro.ipynb Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
…n/02-datagen-intro.ipynb Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
vtlim
left a comment
There was a problem hiding this comment.
Approved after a few remaining nits. Really nice work!
Description
Release note
Jupyter Labs quick start now contains a data generator to create batch or streaming data on demand.
This PR has: