Fix the bug in getIndexInfo for mysql#14750
Merged
clintropolis merged 1 commit intoapache:masterfrom Aug 4, 2023
Merged
Conversation
clintropolis
approved these changes
Aug 4, 2023
| return databaseMetaData.getIndexInfo( | ||
| null, | ||
| null, | ||
| tableName, // tableName is case-sensitive in mysql default setting |
Contributor
There was a problem hiding this comment.
what was the reason for wrapping this in upperCase call anyway?
Contributor
Author
There was a problem hiding this comment.
Default Derby settings needs tableName in uppercase, else it does not return the indexInfo.
AmatyaAvadhanula
pushed a commit
to AmatyaAvadhanula/druid
that referenced
this pull request
Aug 4, 2023
abhishekagarwal87
pushed a commit
that referenced
this pull request
Aug 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the bug in getIndex List on given table, mysql implementation of DatabaseMetadata has different behavior then Derby, default settings in mysql are strict and accept only case sensitive name of the tableName in databaseMetaData.getIndexInfo, while in derby it strictly accept the upper case.
I am moving this databaseMetaData.getIndexInfo to connector specific overrides.
I have tested this PR on docker based MySQL metadata connector, local docker based mariadb as well as Postgres and it works well.
This PR has: