Skip streaming auto-scaling action if supervisor is idle#14773
Merged
jon-wei merged 2 commits intoapache:masterfrom Aug 18, 2023
Merged
Skip streaming auto-scaling action if supervisor is idle#14773jon-wei merged 2 commits intoapache:masterfrom
jon-wei merged 2 commits intoapache:masterfrom
Conversation
abhishekrb19
reviewed
Aug 7, 2023
.../main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java
Outdated
Show resolved
Hide resolved
…blestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Abhishek Radhakrishnan <abhishek.rb19@gmail.com>
abhishekrb19
approved these changes
Aug 7, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| EasyMock.expect(spec.getSupervisorStateManagerConfig()).andReturn(supervisorConfig).anyTimes(); | ||
|
|
||
| EasyMock.expect(spec.getDataSchema()).andReturn(getDataSchema()).anyTimes(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
zachjsh
reviewed
Aug 17, 2023
| return; | ||
| } | ||
| if (SupervisorStateManager.BasicState.IDLE == getState()) { | ||
| log.info( |
Contributor
There was a problem hiding this comment.
How often does this get logged? Seems like once a minute by default? Should we lower to debug?
zachjsh
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the streaming supervisor task auto-scaling will continue to submit taskCount changes when the supervisor is idle (with 0 running tasks in IDLE state, the auto-scaling believes it needs to update the taskCount to the desired count). This can lead to a large buildup of redundant supervisor specs in the supervisor history.
This PR has: