Use num cores to determine balancerComputeThreads#14902
Merged
kfaraz merged 3 commits intoapache:masterfrom Aug 25, 2023
Merged
Use num cores to determine balancerComputeThreads#14902kfaraz merged 3 commits intoapache:masterfrom
kfaraz merged 3 commits intoapache:masterfrom
Conversation
clintropolis
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
balancerComputeThreadsbased on number of coordinator cpus rather than number of segments. Even if the number of segments is low and we create more balancer threads, it doesn't hurt the system as threads would mostly be idle.SegmentLoadQueueManagerExpected values
Release note
The coordinator dynamic config now uses
num_cpus / 2as the default value forbalancerComputeThreadsinstead of the old value of1.This is also the value used when
smartSegmentLoadingis enabled.This PR has: