Fix StringLastAggregatorFactory equals/toString#14907
Merged
soumyava merged 15 commits intoapache:masterfrom Sep 8, 2023
Merged
Fix StringLastAggregatorFactory equals/toString#14907soumyava merged 15 commits intoapache:masterfrom
soumyava merged 15 commits intoapache:masterfrom
Conversation
This reverts commit 44992cb.
somu-imply
reviewed
Aug 29, 2023
...ssing/src/main/java/org/apache/druid/query/aggregation/last/StringLastAggregatorFactory.java
Show resolved
Hide resolved
somu-imply
reviewed
Sep 8, 2023
| @@ -302,6 +303,7 @@ public String toString() | |||
| "fieldName='" + fieldName + '\'' + | |||
| ", name='" + name + '\'' + | |||
| ", maxStringBytes=" + maxStringBytes + | |||
Contributor
There was a problem hiding this comment.
Suggested change
| ", maxStringBytes=" + maxStringBytes + | |
| ", maxStringBytes=" + maxStringBytes + '\'' + |
Member
Author
There was a problem hiding this comment.
I think we don't necessarily need to quote this; as its an integer
I see other places where the same value is shown in toString and its not quoted there
but in case we do; we should quote it from both sides
Contributor
There was a problem hiding this comment.
Blahh that's an integer, I'll merge this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
StringLastAggregatorFactoryclass;equals/toStringwere not accounting for thetimeColumnfield.