Skip to content

Comments

Increase the computed value of replicationThrottleLimit#14913

Merged
kfaraz merged 2 commits intoapache:masterfrom
kfaraz:speed_up_replication
Aug 28, 2023
Merged

Increase the computed value of replicationThrottleLimit#14913
kfaraz merged 2 commits intoapache:masterfrom
kfaraz:speed_up_replication

Conversation

@kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Aug 28, 2023

Description

In the smartSegmentLoading mode, the Coordinator is able to handle unlimited load queues.

So, it is safe to increase the computed values of replicationThrottleLimit to allow segments to reach max replication levels faster.

It is possible to even completely remove the replicationThrottleLimit but we would want to retain it to prevent unnecessary loads on servers in case a server disappears from the cluster intermittently.

Changes

  • Increase value of replicationThrottleLimit computed by smartSegmentLoading from 2% to 5% of total number of used segments.
  • Assign replicas to a tier even when some replicas are already being loaded in that tier
  • Limit the total number of replicas in load queue at start of run + replica assignments in the run to the replicationThrottleLimit.
for every tier,
    num replicas in load queue at start of run + num replicas assigned in run <= replicationThrottleLimit

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz changed the title Increasing the computed value of replicationThrottleLimit Increase the computed value of replicationThrottleLimit Aug 28, 2023
Copy link
Contributor

@AmatyaAvadhanula AmatyaAvadhanula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! +1 after all the checks pass

@kfaraz kfaraz merged commit d6565f4 into apache:master Aug 28, 2023
@kfaraz kfaraz deleted the speed_up_replication branch August 28, 2023 12:50
@kfaraz
Copy link
Contributor Author

kfaraz commented Aug 28, 2023

Thanks for the review, @AmatyaAvadhanula !

@LakshSingla LakshSingla added this to the 28.0 milestone Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants