Increase the computed value of replicationThrottleLimit#14913
Merged
kfaraz merged 2 commits intoapache:masterfrom Aug 28, 2023
Merged
Increase the computed value of replicationThrottleLimit#14913kfaraz merged 2 commits intoapache:masterfrom
kfaraz merged 2 commits intoapache:masterfrom
Conversation
AmatyaAvadhanula
approved these changes
Aug 28, 2023
Contributor
AmatyaAvadhanula
left a comment
There was a problem hiding this comment.
LGTM! +1 after all the checks pass
Contributor
Author
|
Thanks for the review, @AmatyaAvadhanula ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the
smartSegmentLoadingmode, the Coordinator is able to handle unlimited load queues.So, it is safe to increase the computed values of
replicationThrottleLimitto allow segments to reach max replication levels faster.It is possible to even completely remove the
replicationThrottleLimitbut we would want to retain it to prevent unnecessary loads on servers in case a server disappears from the cluster intermittently.Changes
replicationThrottleLimitcomputed bysmartSegmentLoadingfrom 2% to 5% of total number of used segments.replicationThrottleLimit.This PR has: