Add IS [NOT] TRUE, IS [NOT] FALSE native functions.#14977
Merged
gianm merged 1 commit intoapache:masterfrom Sep 14, 2023
Merged
Add IS [NOT] TRUE, IS [NOT] FALSE native functions.#14977gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
They are not quite the same as "x == true", "x != true", etc. These functions never return null, even when "x" itself is null.
clintropolis
approved these changes
Sep 14, 2023
gianm
added a commit
to gianm/druid
that referenced
this pull request
Sep 14, 2023
These were added in apache#14977, but the implementations are incorrect, because they return null when the input arg is null. They should return false when the input is null. Remove them for now, rather than fixing them, since they're so new that they might as well never have existed.
abhishekagarwal87
pushed a commit
that referenced
this pull request
Sep 25, 2023
These were added in #14977, but the implementations are incorrect, because they return null when the input arg is null. They should return false when the input is null. Remove them for now, rather than fixing them, since they're so new that they might as well never have existed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are not quite the same as "x == true", "x != true", etc. These functions never return null, even when "x" itself is null.