Support getTaskLocation for mixed task runner#15033
Merged
cryptoe merged 2 commits intoapache:masterfrom Sep 27, 2023
Merged
Conversation
cryptoe
reviewed
Sep 26, 2023
| @Override | ||
| public TaskLocation getTaskLocation(String taskId) | ||
| { | ||
| TaskLocation taskLocation = kubernetesTaskRunner.getTaskLocation(taskId); |
Contributor
There was a problem hiding this comment.
What's the desired behavior if TaskLocation taskLocation = kubernetesTaskRunner.getTaskLocation(taskId); throws exception?
Shoudn't we fallback to workerTaskRunner ?
Contributor
Author
There was a problem hiding this comment.
i feel it really probably shouldn't throw an exception b/c this is the logic
final KubernetesWorkItem workItem = tasks.get(taskId);
if (workItem == null) {
return TaskLocation.unknown();
} else {
return workItem.getLocation();
}
Contributor
Author
There was a problem hiding this comment.
i feel like its fine to propagate an exception up b/c something is probably v wrong if it does throw one
cryptoe
approved these changes
Sep 27, 2023
Contributor
cryptoe
left a comment
cryptoe
left a comment
There was a problem hiding this comment.
Changes LGTM. Thanks for the patch @georgew5656!!
FrankChen021
pushed a commit
that referenced
this pull request
Feb 3, 2025
The KubernetesAndWorkerTaskRunner currently doesn't implement getTaskLocation, so tasks run by it will show a unknown TaskLocation in the druid console after a task has completed. Fix bug in KubernetesAndWorkerTaskRunner that manifests as missing information in the druid Web Console.
GabrielCWT
pushed a commit
to GabrielCWT/druid
that referenced
this pull request
Sep 9, 2025
The KubernetesAndWorkerTaskRunner currently doesn't implement getTaskLocation, so tasks run by it will show a unknown TaskLocation in the druid console after a task has completed. Fix bug in KubernetesAndWorkerTaskRunner that manifests as missing information in the druid Web Console.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The KubernetesAndWorkerTaskRunner currently doesn't implement getTaskLocation, so tasks run by it will show a unknown TaskLocation in the druid console after a task has completed.
Release note
Fix bug in KubernetesAndWorkerTaskRunner that manifests as missing information in the druid Web Console.
Key changed/added classes in this PR
KubernetesAndWorkerTaskRunner