Add table sampling with fixed shard#15128
Closed
takaaki7 wants to merge 4 commits intoapache:masterfrom
takaaki7:add_table_sampling
Closed
Add table sampling with fixed shard#15128takaaki7 wants to merge 4 commits intoapache:masterfrom takaaki7:add_table_sampling
takaaki7 wants to merge 4 commits intoapache:masterfrom
takaaki7:add_table_sampling
Conversation
added 2 commits
October 11, 2023 15:42
added 2 commits
October 12, 2023 18:48
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| if (baseDataSource instanceof TableDataSource) { | ||
| return Optional.of((TableDataSource) baseDataSource); | ||
| } else if (baseDataSource instanceof SampledTableDataSource) { |
Check failure
Code scanning / CodeQL
Contradictory type checks
| if (baseDataSource instanceof TableDataSource) { | ||
| return Optional.of((TableDataSource) baseDataSource); | ||
| } else if (baseDataSource instanceof SampledTableDataSource) { | ||
| return Optional.of((SampledTableDataSource) baseDataSource); |
Check failure
Code scanning / CodeQL
Contradictory type checks
| public boolean isTableBased() | ||
| { | ||
| return (baseDataSource instanceof TableDataSource | ||
| || baseDataSource instanceof SampledTableDataSource |
Check failure
Code scanning / CodeQL
Contradictory type checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15140 .
Description
Add fixed shard table sampling for native query. The details is described in issue.
Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: