Order by plan fail with an ORDER BY under an aggregate#15235
Closed
somu-imply wants to merge 7 commits intoapache:masterfrom
Closed
Order by plan fail with an ORDER BY under an aggregate#15235somu-imply wants to merge 7 commits intoapache:masterfrom
somu-imply wants to merge 7 commits intoapache:masterfrom
Conversation
Contributor
somu-imply
commented
Oct 23, 2023
somu-imply
commented
- been self-reviewed.
- using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
- added documentation for new or modified features or behaviors.
- a release note entry in the PR description.
- added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- added or updated version, license, or notice information in licenses.yaml
- added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
- added integration tests.
- been tested in a test Druid cluster.
Contributor
Author
|
Although this works for the case I can find a counter example which will fail this. Not proceeding with this idea for the regression fix in 28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.