Skip to content

[backport]Suggest adoption of Google Style guide (#14905)#15304

Merged
317brian merged 1 commit intoapache:28.0.0from
techdocsmith:backport_style
Nov 2, 2023
Merged

[backport]Suggest adoption of Google Style guide (#14905)#15304
317brian merged 1 commit intoapache:28.0.0from
techdocsmith:backport_style

Conversation

@techdocsmith
Copy link
Contributor

@techdocsmith techdocsmith commented Nov 1, 2023 •
edited by 317brian
Loading

Backports #15304

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@techdocsmith @vtlim
Suggest adoption of Google Style guide (apache#14905)
37ae46b 
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
@techdocsmith techdocsmith requested a review from 317brian November 1, 2023 20:42
@317brian 317brian changed the title Suggest adoption of Google Style guide (#14905) [backport]Suggest adoption of Google Style guide (#14905) Nov 1, 2023
317brian
317brian approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@317brian 317brian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@317brian 317brian merged commit af6ac26 into apache:28.0.0 Nov 2, 2023
@clintropolis clintropolis added this to the 28.0 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@317brian 317brian 317brian approved these changes

Assignees

No one assigned

Labels

Area - Documentation Backport

Projects

None yet

Milestone

28.0

Development

Successfully merging this pull request may close these issues.

3 participants

@techdocsmith @317brian @clintropolis