Add test to verify sequence name of Kafka task#15397
Merged
AmatyaAvadhanula merged 3 commits intoapache:masterfrom Nov 21, 2023
Merged
Add test to verify sequence name of Kafka task#15397AmatyaAvadhanula merged 3 commits intoapache:masterfrom
AmatyaAvadhanula merged 3 commits intoapache:masterfrom
Conversation
AmatyaAvadhanula
approved these changes
Nov 21, 2023
yashdeep97
pushed a commit
to yashdeep97/druid
that referenced
this pull request
Dec 1, 2023
* Add test to verify sequence name of Kafka and Kinesis tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequence name of a streaming task is determined by hashing the following:
Thus even if a task fails and another task is created to ingest that data, it gets assigned the same offset and would thus use the same
sequence_namefor segment allocation.This PR only adds a simple test to verify that the sequence name does not depend on the task ID.
More tests can be later added around the sequence name to verify the other fields that affect the sequence name.