Skip to content

Use ⌘/Ctrl+K shortcut to trigger search bar of official site#15652

Merged
asdf2014 merged 1 commit intoapache:masterfrom
yuanlihan:add-shortcut-to-trigger-search-bar-of-official-site
Jan 10, 2024
Merged

Use ⌘/Ctrl+K shortcut to trigger search bar of official site#15652
asdf2014 merged 1 commit intoapache:masterfrom
yuanlihan:add-shortcut-to-trigger-search-bar-of-official-site

Conversation

@yuanlihan
Copy link
Contributor

Feature discussion: https://apachedruidworkspace.slack.com/archives/C030K0Z7S1Z/p1704425833732369

Description

This PR adds shortcut, ⌘+K or Ctrl+K, to trigger the search bar of official site, see below demo

Screen.Recording.2024-01-05.at.11.31.09.mov

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Member

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@asdf2014 asdf2014 merged commit 99d4b7d into apache:master Jan 10, 2024
@317brian
Copy link
Contributor

317brian commented Jan 10, 2024

The prod site is built by https://github.com/apache/druid-website-src, so this change also needs to be added to that repo for it to be used on the prod site. We'll make a PR for it over there and get it merged. Thanks for doing the hard part @yuanlihan!

@yuanlihan
Copy link
Contributor Author

@317brian Thank you so much!

@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants