Merged
Conversation
kgyrtkirk
approved these changes
Jan 10, 2024
Member
kgyrtkirk
left a comment
There was a problem hiding this comment.
right now I think q.getResultRowAggregatorStart() should be 0 when it gets here in every case; however the correct index is q.getResultRowAggregatorStart() + i
because we may never know what changes will land in the future its better to fix it than leave it!
clintropolis
approved these changes
Jan 11, 2024
soumyava
approved these changes
Jan 11, 2024
LakshSingla
added a commit
to LakshSingla/druid
that referenced
this pull request
Jan 30, 2024
This PR fixes the summary iterator to add aggregators in the correct position. The summary iterator is used when dims are not present, therefore the new change is identical to the old one, but seems more correct while reading.
abhishekagarwal87
pushed a commit
that referenced
this pull request
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the summary iterator to add aggregators in the correct position. The summary iterator is used when dims are not present, therefore the new change is identical to the old one, but seems more correct while reading.
Key changed/added classes in this PR
This PR has: