Skip to content

Refactor: Cleanup test impls of ServiceEmitter#15683

Merged
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:cleanup_test_emitter
Jan 15, 2024
Merged

Refactor: Cleanup test impls of ServiceEmitter#15683
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:cleanup_test_emitter

Conversation

@kfaraz
Copy link
Contributor

@kfaraz kfaraz commented Jan 15, 2024

Changes

  • Use StubServiceEmitter wherever applicable in tests
  • Remove other redundant test implementations

Copy link
Contributor

@AmatyaAvadhanula AmatyaAvadhanula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfaraz kfaraz merged commit 18d2a89 into apache:master Jan 15, 2024
@kfaraz kfaraz deleted the cleanup_test_emitter branch January 15, 2024 12:07
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants