Skip to content

Temporarily bump up delay in security auth IT from 5s to 10s#15765

Merged
zachjsh merged 1 commit intoapache:masterfrom
abhishekrb19:bump_delay_auth_it
Jan 26, 2024
Merged

Temporarily bump up delay in security auth IT from 5s to 10s#15765
zachjsh merged 1 commit intoapache:masterfrom
abhishekrb19:bump_delay_auth_it

Conversation

@abhishekrb19
Copy link
Contributor

@abhishekrb19 abhishekrb19 commented Jan 26, 2024

A follow up to #15679: temporarily bump up the delay from 5s to 10s as the security IT been flaking relatively frequently. I think a more comprehensive fix would be to have status checks/"readiness" endpoints exposed by the different services, but that'll require more code changes. So in the interim, to unblock CI, temporarily bump up the delay.

A few runs where this failure was observed:

The stacktrace of the failing test:

Error:  test_avaticaQueryWithContext_datasourceAndContextParamsUser_succeed(org.apache.druid.tests.security.ITBasicAuthConfigurationTest)  Time elapsed: 0.15 s  <<< FAILURE!
java.lang.RuntimeException: org.apache.calcite.avatica.AvaticaSqlException: Error 2 (00002) : Error while executing SQL "SELECT * FROM INFORMATION_SCHEMA.COLUMNS": Remote driver error: Unauthorized
Caused by: org.apache.calcite.avatica.AvaticaSqlException: Error 2 (00002) : Error while executing SQL "SELECT * FROM INFORMATION_SCHEMA.COLUMNS": Remote driver error: Unauthorized

Error:  test_avaticaQueryWithContext_datasourceOnlyUser_fail(org.apache.druid.tests.security.ITBasicAuthConfigurationTest)  Time elapsed: 0.063 s
Error:  test_avaticaQuery_broker(org.apache.druid.tests.security.ITBasicAuthConfigurationTest)  Time elapsed: 2.713 s
Error:  test_avaticaQuery_router(org.apache.druid.tests.security.ITBasicAuthConfigurationTest)  Time elapsed: 0.269 s
Error:  test_groupMappings_invalidAuthName_fails(org.apache.druid.tests.security.ITBasicAuthConfigurationTest)  Time elapsed: 0.032 s
Error:  test_internalSystemUser_hasNodeAccess(org.apache.druid.tests.security.ITBasicAuthConfigurationTest)  Time elapsed: 0.02 s
Error:  test_sqlQueryWithContext_datasourceAndContextParamsUser_succeed(org.apache.druid.tests.security.ITBasicAuthConfigurationTest)  Time elapsed: 0.532 s
Error:  test_sqlQueryWithContext_datasourceOnlyUser_fail(org.apache.druid.tests.security.ITBasicAuthConfigurationTest)  Time elapsed: 0.048 s

This PR has:

  • been self-reviewed.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader..

A more ideal/permanent fix would be to have status checks exposed by the services,
but that'll require more code changes. So temporarily bump it to unblock CI now.
@zachjsh zachjsh merged commit a7918be into apache:master Jan 26, 2024
@abhishekrb19 abhishekrb19 deleted the bump_delay_auth_it branch January 27, 2024 00:35
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 30, 2024
LakshSingla pushed a commit to LakshSingla/druid that referenced this pull request Jan 30, 2024
A more ideal/permanent fix would be to have status checks exposed by the services,
but that'll require more code changes. So temporarily bump it to unblock CI now.
abhishekagarwal87 pushed a commit that referenced this pull request Jan 30, 2024
…5797)

A more ideal/permanent fix would be to have status checks exposed by the services,
but that'll require more code changes. So temporarily bump it to unblock CI now.

Co-authored-by: Abhishek Radhakrishnan <abhishek.rb19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants