Remove TestObjectMapper in favor of DefaultObjectMapper#15769
Merged
abhishekrb19 merged 1 commit intoapache:masterfrom Jan 27, 2024
Merged
Remove TestObjectMapper in favor of DefaultObjectMapper#15769abhishekrb19 merged 1 commit intoapache:masterfrom
TestObjectMapper in favor of DefaultObjectMapper#15769abhishekrb19 merged 1 commit intoapache:masterfrom
Conversation
Remove dilemma on what object mapper class to use in tests since the DefaultObjectMapper class provides all the same settings and goodies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by a code review where there was a dilemma on which object mapper to use in tests. This PR removes
TestObjectMapperand replaces the references withDefaultObjectMapper. Most tests useDefaultObjectMapperalready, which provides the same mapper settings asTestObjectMapper, serde goodies, and more.