Update the link of Helm Chart to avoid 404 error#15905
Merged
Conversation
Contributor
|
How about leaving a note in docs that point to your repo? So someone searching for helm charts could at least find the charts in your repo. |
Member
Author
|
@abhishekagarwal87 Yes, that'll be great. Please feel free to raise another PR to add note in docs, meanwhile let's focus on updating the links here, how does that sound to you 😄 |
Contributor
|
Why not do it in this PR itself? :) |
Member
Author
|
@abhishekagarwal87 I think we should ensure that the content of the PR closely aligns with the theme as much as possible. Content with weaker relevance can be included in subsequent PRs, making it easier to review the code. :) |
FrankChen021
approved these changes
Feb 21, 2024
Member
FrankChen021
left a comment
There was a problem hiding this comment.
Let's fix the link first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because a new code repository has been created to maintain the Helm Chart for Apache Druid, the links inside the README have been updated to avoid 404 error. We can merge this after #15904
This PR has: