Make setting QUERY_CONTEXT_DEFAULT explicit in tests#16010
Merged
LakshSingla merged 1 commit intoapache:masterfrom Mar 5, 2024
Merged
Make setting QUERY_CONTEXT_DEFAULT explicit in tests#16010LakshSingla merged 1 commit intoapache:masterfrom
LakshSingla merged 1 commit intoapache:masterfrom
Conversation
* prioritize the last added matcher in DruidExceptionMatcher * it adds quite a few matchers and the most interesting one which checks the messages is at the end; showing the message could give better detail about what went wrong (instead of Person mismatch) * this made 2 more tests pass * remove smart defaulting to some QUERY_CONTEXT values in case they are not supplied * there are tests which do rely on some context values set - especially the ones which use the timestamp * it also made it unnecessary to explain in long comments why something is happening * add some basic report generator for not-yet-supported annotated things
kgyrtkirk
changed the title
LakshSingla
approved these changes
Mar 5, 2024
Contributor
|
I was surprised that not many tests required the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has: