Fix race in BaseNodeRoleWatcher tests#16064
Merged
gianm merged 2 commits intoapache:masterfrom Mar 7, 2024
Merged
Conversation
gianm
reviewed
Mar 6, 2024
| } | ||
| } | ||
|
|
||
| static void scheduleTimeout( |
Contributor
There was a problem hiding this comment.
This works, but it'd be nicer as a non-static method, so the caller doesn't need to pass in the executor. The watcher has the listenerExecutor already, so as a non-static this would be:
void scheduleTimeout(long timeoutSeconds)
{
listenerExecutor.schedule(
this::cacheInitializedTimedOut,
timeout,
TimeUnit.SECONDS
);
}| TimeUnit.SECONDS | ||
| ); | ||
| BaseNodeRoleWatcher nodeRoleWatcher = new BaseNodeRoleWatcher(listenerExecutor, nodeRole); | ||
| scheduleTimeout(nodeRoleWatcher, listenerExecutor, DEFAULT_TIMEOUT_SECONDS); |
Contributor
There was a problem hiding this comment.
See other comment about making scheduleTimeout an instance method; then this would simply be nodeRoleWatcher.scheduleTimeout(DEFAULT_TIMEOUT_SECONDS);
| assertListener(listener1, false, Collections.emptyList(), Collections.emptyList()); | ||
|
|
||
| Assert.assertTrue(listener1.ready.await(1500, TimeUnit.MILLISECONDS)); | ||
| BaseNodeRoleWatcher.scheduleTimeout(nodeRoleWatcher, exec, 0); |
gianm
approved these changes
Mar 7, 2024
Contributor
|
thank you @AmatyaAvadhanula ! |
AmatyaAvadhanula
added a commit
to AmatyaAvadhanula/druid
that referenced
this pull request
Mar 8, 2024
* Fix race in BaseNodeRoleWatcher tests * Make non static
AmatyaAvadhanula
added a commit
that referenced
this pull request
Mar 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR to #15726
Addresses the comments:
This PR has: