Skip to content

Add security ITs for sending tasks to overlord#16131

Merged
cryptoe merged 3 commits intoapache:masterfrom
adarshsanjeev:overlord-security-test
Mar 18, 2024
Merged

Add security ITs for sending tasks to overlord#16131
cryptoe merged 3 commits intoapache:masterfrom
adarshsanjeev:overlord-security-test

Conversation

@adarshsanjeev
Copy link
Contributor

Add additional security ITs for sending export tasks directly to overlord

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added the GHA label Mar 15, 2024
securityClient.setPermissionsToRole(ROLE_1, permissions);

// Wait for a second so that the auth is synced, to avoid flakiness
Thread.sleep(1000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if there is a better way to check this.
We can do a follow up if we find this breaking in future releases.

@cryptoe cryptoe merged commit 86a2401 into apache:master Mar 18, 2024
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants