Fixing corner case when only one of upper or lower range is unbounded…#16154
Fixing corner case when only one of upper or lower range is unbounded…#16154somu-imply wants to merge 4 commits intoapache:masterfrom
Conversation
… in a window range
sreemanamala
left a comment
sreemanamala
left a comment
There was a problem hiding this comment.
overall LGTM. Solves the case.
Comment could be updated to when numRows equal to upperOffset rather than just values are 1
somu-imply
force-pushed
the
window_unbounded_range
branch
from
3a84267 to
145b404
Compare
| // In such a case the priming of results is not needed | ||
| if (rowIdProvider.get() == numRows) { | ||
| for (int i = 0; i < aggs.length; i++) { | ||
| results[i][resultStorageIndex] = aggs[i].get(); |
There was a problem hiding this comment.
this should now be
results[i][resultStorageIndex] = aggFactories[i].finalizeComputation(aggs[i].get())
since this PR
Similarly in reverse cummulative aggregate as well
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
This pull request/issue has been closed due to lack of activity. If you think that |
3 participants
… in a window range
Previously a query with an upper or lower offset of 1 on a window with a single row was throwing a NPE as below
as the corner case was not handled correctly. This PR handles the cases and examples are added
This PR has: