update code style for task type#16343
Merged
abhishekrb19 merged 2 commits intoapache:masterfrom Apr 29, 2024
Merged
Conversation
kfaraz
approved these changes
Apr 28, 2024
Contributor
Author
|
The failed check is cause by "Rate limit reached" |
abhishekrb19
approved these changes
Apr 28, 2024
| */ | ||
| public class NoopTask extends AbstractTask implements PendingSegmentAllocatingTask | ||
| { | ||
| public static final String TYPE = "noop"; |
Contributor
There was a problem hiding this comment.
We can also change getType() to return TYPE instead of the hardcoded value
Contributor
Author
There was a problem hiding this comment.
good catch and fixed.
|
|
||
| public class HadoopIndexTask extends HadoopTask implements ChatHandler | ||
| { | ||
| public static final String TYPE = "index_hadoop"; |
Contributor
There was a problem hiding this comment.
Same here regarding getType() using TYPE.
Contributor
Author
There was a problem hiding this comment.
good catch and fixed.
cryptoe
approved these changes
Apr 29, 2024
Contributor
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes code style for task type
Description
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
improve the code style of task type, to be consistent for each sub task
Key changed/added classes in this PR
AppenderatorDriverRealtimeIndexTask.javaArchiveTask.javaCompactionTask.javaHadoopIndexTask.javaIndexTask.javaMoveTask.javaNoopTask.javaRealtimeIndexTask.javaRestoreTask.javaTask.javaThis PR has: