Merged
Conversation
whether a catalog table or not
it in order to specify clustering
kgyrtkirk
approved these changes
May 3, 2024
Member
kgyrtkirk
left a comment
kgyrtkirk
left a comment
There was a problem hiding this comment.
+1
left some notes; can be addressed in next pr as well
|
|
||
| public class EditorTest | ||
| { | ||
| private static final ObjectMapper MAPPER = new DefaultObjectMapper(); |
Member
There was a problem hiding this comment.
note: dbFixture also has an OM you could probably reuse that somehow; I've seen some issue arising from using different objectmappers...
| doEdit(tableName, cmd).spec().properties() | ||
| ); | ||
|
|
||
| // Add a DESC cluster key - should fail |
Member
There was a problem hiding this comment.
could be placed in a new testscase
| expectValidationFails(spec); | ||
| } | ||
|
|
||
| { |
Member
There was a problem hiding this comment.
aren't these 2 separate testcases?
IgorBerman
pushed a commit
to IgorBerman/druid
that referenced
this pull request
May 5, 2024
* * add another catalog clustering columns unit test * * dissallow clusterKeys with descending order * * make more clear that clustering is re-written into ingest node whether a catalog table or not * * when partitionedBy is stored in catalog, user shouldnt need to specify it in order to specify clustering * * fix intellij inspection failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr contains a few fixes for clustering keys when stored in the Druid table catalog.
DESCorder clustering keys is disallowed; descending clustering keys is not supported at this time by Druid, but previously users could create / update a catalog table with clustering keys withDESCorder via api. This is now disallowed.DruidSqlValidator. In such a case the user should be able to omit the partitioning at query time, and still specify the clustering at query time.This PR has: