Docs: Remove references to Zk-based segment loading#16360
Merged
kfaraz merged 1 commit intoapache:masterfrom May 1, 2024
Merged
Docs: Remove references to Zk-based segment loading#16360kfaraz merged 1 commit intoapache:masterfrom
kfaraz merged 1 commit intoapache:masterfrom
Conversation
abhishekrb19
approved these changes
Apr 30, 2024
|
|
||
| `druid.zk.service.enabled=false` | ||
| `druid.serverview.type=http` | ||
| `druid.coordinator.loadqueuepeon.type=http` |
Contributor
There was a problem hiding this comment.
There's one more reference in integration-tests/k8s/tiny-cluster.yaml: druid.coordinator.loadqueuepeon.type=http which can also be removed.
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this, @abhishekrb19 . There are a couple more references in the code that I plan to tackle in a separate PR. Keeping this one only for the docs changes.
317brian
pushed a commit
to 317brian/druid
that referenced
this pull request
Jan 28, 2025
ZK-based segment loading was completely disabled in apache#16360 and apache#15705. This PR removes all related code which is now unused. Changes: - Remove CuratorLoadQueuePeon and CuratorLoadQueuePeonTest - Refactor DruidCoordinatorTest to use a TestLoadQueuePeon instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #15705
Changes:
druid.coordinator.loadqueuepeon.http.repeatDelay